refactoring and rubocop changes

app/controllers/users_controller.rb

@@ -39,16 +39,9 @@ class UsersController < ApplicationController
   end
 
   def recover_password
-    user = User.find(params[:user_id])
+    @user = User.find(params[:user_id])
-    if user.recovery_password_digest && user.authenticate_recovery_password(params[:recovery_password])
+    if recovery_password_proper?
-      user.password = params[:password]
+      set_new_password
-      user.password_confirmation = params[:password_confirmation]
-      if user.save
-        user.update(recovery_password: nil)
-        redirect_to '/welcome', notice: 'Password changed'
-      else
-        redirect_to '/welcome', notice: 'Passwords don\'t match'
-      end
     else
       redirect_to '/welcome', notice: 'Recovery link expired or invalid'
     end
@@ -63,4 +56,22 @@ class UsersController < ApplicationController
     User.find(params[:id]).update(status: :blocked)
     redirect_to '/users'
   end
+
+  private
+
+  def recovery_password_proper?
+    @user.recovery_password_digest &&
+      @user.authenticate_recovery_password(params[:recovery_password])
+  end
+
+  def set_new_password
+    @user.password = params[:password]
+    @user.password_confirmation = params[:password_confirmation]
+    if @user.save
+      @user.update(recovery_password: nil)
+      redirect_to '/welcome', notice: 'Password changed'
+    else
+      redirect_to '/welcome', notice: 'Passwords don\'t match'
+    end
+  end
 end

app/helpers/application_helper.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
 
+# Application helper
 module ApplicationHelper
 end

app/helpers/books_helper.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+# Books helper
 module BooksHelper
   def cart_summary
     number_to_currency(@books.map(&:price).reduce(:+))

app/helpers/sessions_helper.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
 
+# Sessions helper
 module SessionsHelper
 end

app/helpers/users_helper.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
 
+# Users helper
 module UsersHelper
 end

app/mailers/user_mailer.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+# User mailer
 class UserMailer < ApplicationMailer
   def password_recovery
     @user = params[:user]

app/models/application_record.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+# Application record
 class ApplicationRecord < ActiveRecord::Base
   self.abstract_class = true
   def update(*args)

app/presenters/books_presenter.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+# Books presenter
 class BooksPresenter < SimpleDelegator
   include ActiveSupport::NumberHelper
 

config/application.rb

@@ -8,6 +8,7 @@ require 'rails/all'
 # you've limited to :test, :development, or :production.
 Bundler.require(*Rails.groups)
 
+# App
 module App
   class Application < Rails::Application
     # Initialize configuration defaults for originally generated Rails version.

db/migrate/20210319142051_create_authors.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+# Create authors
 class CreateAuthors < ActiveRecord::Migration[6.1]
   def change
     create_table :authors do |t|

db/migrate/20210319142054_create_books.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+# Create books
 class CreateBooks < ActiveRecord::Migration[6.1]
   def change
     create_table :books do |t|

db/migrate/20210319142059_create_authors_books.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+# Create association table between authors and books
 class CreateAuthorsBooks < ActiveRecord::Migration[6.1]
   def change
     create_table :authors_books do |t|

db/migrate/20210320130542_create_users.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+# Create users
 class CreateUsers < ActiveRecord::Migration[6.1]
   def change
     create_table :users do |t|